fix(language-service): do not crash when Angular cannot be located #14123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbosch
reviewed
Jan 30, 2017
| containingFile | ||
| } `: ''}`), | ||
| null); | ||
| return this.getStaticSymbol(module, symbolName); |
There was a problem hiding this comment.
Maybe use a fake path so that it is clear that this symbol was produced from an error condition? E.g. this.getStaticSymbol('ERROR', symbolName)?
tbosch
added
the
action: cleanup
tbosch
approved these changes
Jan 30, 2017
chuckjaz
removed
the
action: cleanup
mhevery
approved these changes
Jan 31, 2017
mhevery
pushed a commit
that referenced
this pull request
Feb 2, 2017
mhevery
pushed a commit
that referenced
this pull request
Feb 3, 2017
mhevery
pushed a commit
to mhevery/angular
that referenced
this pull request
Feb 3, 2017
mhevery
pushed a commit
to mhevery/angular
that referenced
this pull request
Feb 3, 2017
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14122
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
The language service crashes when open on project that does not contain angular (#14122)
What is the new behavior?
The language service returns undefined for all calls.
Does this PR introduce a breaking change? (check one with "x")